Crash when updating library

Hi.

My vero4k+ is crashing when I attempt a library update, and it tries to process a new file.

Thanks to attaching strace to it, I’ve narrowed it down to when it’s reading the NFO file for the episode it’s trying to add. For instance:

[pid 3492] read(39, <unfinished …>
[pid 3562] open("/tbla/video/tv/8 Out of 10 Cats/season21/8 Out of 10 Cats - S21E10 - Best Bits, Part 1.nfo", O_RDONLY|O_LARGEFILE) = 36 <0.0102
72>
[pid 3562] read(36, “\357\273\277\n Bes”…, 1996) = 1995 <0.029727>
[pid 3562] read(36, “”, 1) = 0 <0.000021>
[pid 3562] write(2, “kodi.bin: tinyxmlparser.cpp:543:”…, 138) = 138 <0.000071>
[pid 3562] — SIGABRT {si_signo=SIGABRT, si_code=SI_TKILL, si_pid=3413, si_uid=1000} —
[pid 3515] +++ killed by SIGABRT +++
[pid 3530] +++ killed by SIGABRT +++

In this case, I then removed that NFO file, and re-ran the update, and it was able to add the episode.
This is definitely weird new behaviour though, any suggestions?

I’ll provide logs if needed, but they’re kinda useless. In the above case, it just gets truncated at the time of crash:

2020-01-04 15:25:33.422 T:3935298272 DEBUG: VideoInfoScanner: Found episode match /tbla/video/tv/8 Out of 10 Cats/season21/8 Out of 10 Cats - S21E10 - Best Bits, Part 1.mkv (s21e10) [s([0-9]+)[ ._x-]e([0-9]+(?:(?:[a-i]|.[1-9])(?![0-9]))?)([^\/])$]

Probably seeing the contents of the NFO file would be helpful.

Sure! Chucked it up here for you: https://whatevz.net/8%20Out%20of%2010%20Cats%20-%20S21E10%20-%20Best%20Bits,%20Part%201.nfo

Appears to be valid XML in the checker I ran it through. It’s possible the software generating these is doing something wacky. But I’m surprised it’s causing a crash

I don’t see anything obvious, but this one line did look odd:

 <credits>||</credits>

Maybe delete that line and see that happens. Also, while valid XML, maybe the lines like this are causing it:

 <displayseason/>
 <displayepisode/>

There are several like that, try deleting those also.

Ugh, sure enough a recent commit includes the phrase ‘Change output non valid xml that Kodi will accept.’

So I’m going to say this is all my fault for generating bad XML.

It’d be nice if a bad NFO file was ignored, rather than crashing, but oh well

It was valid XML, I guess Kodi just doesn’t like it. Was it the:

<displayseason/>

type lines that caused it?

The line causing it is…
<rating default="" max="10" name="thetvdb">

If you put in a default value it doesn’t crash

1 Like

Looking at a valid rating from one of my NFOs it should look like:

<ratings>
    <rating name="default" max="10" default="true">
        <value>6.700000</value>
        <votes>13</votes>
    </rating>
</ratings>

I don’t know that it cares what is there. Once I narrowed down where the crash was I just put a “0” in the quotes and it was happy with that. But it looks like TVDB is using…

   <ratings>
        <rating name="tvdb" max="10" default="true">
            <value>8.000000</value>
            <votes>16</votes>
        </rating>
    </ratings>

That explains the problem for my issue as well! Thanks :slight_smile: