Thanks for the revised build! I may not have time to test it out this weekend with my work schedule, but I’ll aim to test it next weekend at the latest and give you the log results.
Also, I’m assuming you meant chmod 0755 or chmod a+x with this line, in case anyone else wants to test the build?
oops, yes!
Ok, I am totally lost on the new update & Kodi whitelist, my vero4k & 4k+ both changed to whatever the frame rate & resolution was but now just default to 1080i 50 (display) & seems any 24 really 23.9736? material plays back as 1080 60hz but hdr seems towork (tv display info).
How does the white list work, select all in the menu and highlight does this add them? Seems to make no difference what I do. Used to play back at 24p material ok, even 23 fractional stuff, some semi uhd at 3840x1600 as uhd hdr at correct frame rate, now only 1080 50 or 60?
Which earlier osmc version was before this change?
Thanks
You are not alone. It seems if you don’t use the whitelist and set ‘Adjust refresh rate’ to anything but ‘Off’ then you get pretty much the same result as with v17 (Krypton).
If you pick any resolution(s) for the whitelist then Kodi will use only that resolution(s) (if it gets an exact match) or the GUI resolution. Exact match means including the fractional framerates.
Try this and let us know which resolutions are not being displayed as you expect and what you expect them to be displayed as. Logs will help, as always.
If you have a moment, can you post your raw EDID?
cat /sys/class/amhdmitx/amhdmitx0/rawedid | paste-log
Sure thing. Here’s the EDID:
00ffffffffffff0035493400010101010019010380a05a780aee91a3544c99260f5054a108003140454061407140818001010101010108e80030f2705a80b0588a0040846300001e023a801871382d40582c450040846300001e000000fc006d6172616e747a2d4156520a20000000fd003a3e1e883c000a202020202020018502036ff1546110222005040302015d5e5f666263640e230f24350f7f073d1ec01507505f7e03570603677e035f7e01835f00006e030c002600b83c2000800102030467d85dc401788003e30f0110e3060501ee0146d00024180900ad5244a9230ce305c000e200cfe61146d000f00100000000000000000000000000000000f4
Ignoring any limitations of the hardware, most of the elements of the GUI are at a fixed size (movie artwork, icons, etc.). To get full resolution with artwork, you’d have to have large versions of artwork available and use advancedsettings.xml to make sure the artwork isn’t down-scaled before it is cached.
To get full resolution with icons, the skin or add-on icon package would have to provide high-resolution versions.
For other GUI elements, it depends on how they are created. For example, a scrollbar is often just a very small texture that is applied to the area occupied by the scroll bar. This will scale perfectly with higher resolutions, as would fonts. But, anything that uses some sort of fixed-size source will have the same issue as icons.
It does indeed help to use the <[...]res> settings in advancedsettings.xml to get the higher res artwork for backgrounds and the like, but even without setting the additional flags, you’ll find that the default size artwork ends up looking much better when rendered in the television’s native resolution for film covers and the like, since those are so generally so small on-screen that they’re already being downscaled. The single most noticeable difference between rendering in 1080p and rendering 2160p natively on the devices that support both is the legibility of text on the small movie and series posters in the “Wall” views.
If it’s not terribly difficult, I think it would be excellent to enable an option to render the interface in 2160p natively in a test build, so that we could see which skin elements (if any) are potentially problematic. I can honestly say that I never noticed any ugly scaling artifacts with Estuary rendering at 2160p on my Android box, but as I noted in an earlier post, it’s a largely abstract skin, and scaling issues aren’t particularly noticeable on amorphous blobs of color. Since 90% of Kodi’s user interface is just fonts and media art, having minor elements of the skin upscaling suboptimally may be a non-issue.
Thanks. So I loaded that EDID and did get PAL DVDs playing at 2160p25, but it’s not a happy experience. 1080p60 is much smoother.
I look forward to your findings.
I finally got around to testing this build. I tested the following with the interface starting off in 1080p@60Hz. I also disabled the 1080p@50Hz in the whitelist that I had added via information I asked in a previous thread.
Both of these operate as I would have expected.
Thank you for your patience; I just got a break from my work schedule to tinker with the media center again, and can report back the following results: The new build works perfectly with the whitelist enabled, but still falls back to the current resolution with the whitelist disabled.
As before, all testing was done with GUI set to 1920x1080 @ 59.94Hz.
1080p25 with whitelist:
2019-05-11 23:06:13.393 T:3636601568 NOTICE: Whitelist search for: width: 1920, height: 1080, fps: 25.000, 3D: false
2019-05-11 23:06:13.393 T:3636601568 DEBUG: Trying to find exact refresh rate
2019-05-11 23:06:13.394 T:3636601568 DEBUG: No exact whitelisted resolution matched, trying double refresh rate
2019-05-11 23:06:13.396 T:3636601568 DEBUG: No double whitelisted resolution matched, trying 3:2 pullback
2019-05-11 23:06:13.397 T:3636601568 DEBUG: No 3:2 pullback whitelisted resolution matched, trying current resolution 1920x1080 @ 59.94 - Full Screen (16)
2019-05-11 23:06:13.397 T:3636601568 DEBUG: Current resolution doesn't match, trying higher resolutions
2019-05-11 23:06:13.398 T:3636601568 DEBUG: Matched whitelisted Resolution 3840x2160 @ 25.00 - Full Screen (31)
2019-05-11 23:06:13.398 T:3636601568 NOTICE: Display resolution ADJUST : 3840x2160 @ 25.00 - Full Screen (31) (weight: 0.000)
1080p24 with whitelist:
2019-05-11 23:06:44.830 T:3636601568 NOTICE: Whitelist search for: width: 1920, height: 1080, fps: 23.976, 3D: false
2019-05-11 23:06:44.830 T:3636601568 DEBUG: Trying to find exact refresh rate
2019-05-11 23:06:44.831 T:3636601568 DEBUG: Matched exact whitelisted Resolution 1920x1080 @ 23.98 - Full Screen (28)
2019-05-11 23:06:44.831 T:3636601568 NOTICE: Display resolution ADJUST : 1920x1080 @ 23.98 - Full Screen (28) (weight: 0.000)
1080p25 without whitelist:
2019-05-11 23:09:25.284 T:3635606240 NOTICE: Whitelist search for: width: 1920, height: 1080, fps: 25.000, 3D: false
2019-05-11 23:09:25.284 T:3635606240 DEBUG: Whitelist is empty using default one
2019-05-11 23:09:25.284 T:3635606240 DEBUG: Found candidate resolution Windowed
2019-05-11 23:09:25.284 T:3635606240 DEBUG: Not added - < current resolution
2019-05-11 23:09:25.284 T:3635606240 DEBUG: Found candidate resolution 1920x1080 @ 59.94 - Full Screen
2019-05-11 23:09:25.284 T:3635606240 DEBUG: Added to default whitelist
2019-05-11 23:09:25.284 T:3635606240 DEBUG: Found candidate resolution 720x480 @ 60.00 - Full Screen
2019-05-11 23:09:25.284 T:3635606240 DEBUG: Not added - < current resolution
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Found candidate resolution 720x480 @ 59.94 - Full Screen
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Not added - < current resolution
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Found candidate resolution 1280x720 @ 60.00 - Full Screen
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Not added - < current resolution
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Found candidate resolution 1280x720 @ 59.94 - Full Screen
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Not added - < current resolution
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Found candidate resolution 1920x1080 @ 60.00i - Full Screen
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Not added - < current resolution
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Found candidate resolution 1920x1080 @ 59.94i - Full Screen
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Not added - < current resolution
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Found candidate resolution 1920x1080 @ 60.00 - Full Screen
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Added to default whitelist
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Found candidate resolution 1920x1080 @ 59.94 - Full Screen
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Added to default whitelist
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Found candidate resolution 1920x1080 @ 30.00 - Full Screen
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Not added - 25 or 30 refresh rate
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Found candidate resolution 1920x1080 @ 29.97 - Full Screen
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Not added - 25 or 30 refresh rate
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Found candidate resolution 1920x1080 @ 24.00 - Full Screen
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Added to default whitelist
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Found candidate resolution 1920x1080 @ 23.98 - Full Screen
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Added to default whitelist
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Found candidate resolution 3840x2160 @ 30.00 - Full Screen
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Not added - 25 or 30 refresh rate
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Found candidate resolution 3840x2160 @ 29.97 - Full Screen
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Not added - 25 or 30 refresh rate
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Found candidate resolution 3840x2160 @ 25.00 - Full Screen
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Not added - 25 or 30 refresh rate
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Found candidate resolution 3840x2160 @ 24.00 - Full Screen
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Added to default whitelist
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Found candidate resolution 3840x2160 @ 23.98 - Full Screen
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Added to default whitelist
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Found candidate resolution 4096x2160 @ 24.00 - Full Screen
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Added to default whitelist
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Found candidate resolution 4096x2160 @ 23.98 - Full Screen
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Added to default whitelist
2019-05-11 23:09:25.285 T:3635606240 DEBUG: Found candidate resolution 3840x2160 @ 60.00 - Full Screen
2019-05-11 23:09:25.286 T:3635606240 DEBUG: Added to default whitelist
2019-05-11 23:09:25.286 T:3635606240 DEBUG: Found candidate resolution 3840x2160 @ 59.94 - Full Screen
2019-05-11 23:09:25.286 T:3635606240 DEBUG: Added to default whitelist
2019-05-11 23:09:25.286 T:3635606240 DEBUG: Found candidate resolution 3840x2160 @ 60.00 - Full Screen
2019-05-11 23:09:25.286 T:3635606240 DEBUG: Added to default whitelist
2019-05-11 23:09:25.286 T:3635606240 DEBUG: Found candidate resolution 3840x2160 @ 59.94 - Full Screen
2019-05-11 23:09:25.286 T:3635606240 DEBUG: Added to default whitelist
2019-05-11 23:09:25.286 T:3635606240 DEBUG: Trying to find exact refresh rate
2019-05-11 23:09:25.286 T:3635606240 DEBUG: No exact whitelisted resolution matched, trying double refresh rate
2019-05-11 23:09:25.287 T:3635606240 DEBUG: No double whitelisted resolution matched, trying 3:2 pullback
2019-05-11 23:09:25.288 T:3635606240 DEBUG: No 3:2 pullback whitelisted resolution matched, trying current resolution 1920x1080 @ 59.94 - Full Screen (16)
2019-05-11 23:09:25.288 T:3635606240 DEBUG: Current resolution doesn't match, trying default resolution 1920x1080 @ 59.94 - Full Screen
2019-05-11 23:09:25.291 T:3635606240 DEBUG: Default resolution doesn't provide required refreshrate, trying default resolution with double refreshrate
2019-05-11 23:09:25.292 T:3635606240 DEBUG: Default resolution doesn't provide reqired refreshrate, trying default resolution with 3:2 pullback
2019-05-11 23:09:25.292 T:3635606240 DEBUG: No whitelisted resolution matched
2019-05-11 23:09:25.292 T:3635606240 NOTICE: Display resolution ADJUST : 1920x1080 @ 59.94 - Full Screen (16) (weight: 0.000)
1080p24 without whitelist:
2019-05-11 23:09:36.131 T:3564675808 NOTICE: Whitelist search for: width: 1920, height: 1080, fps: 23.976, 3D: false
2019-05-11 23:09:36.131 T:3564675808 DEBUG: Whitelist is empty using default one
2019-05-11 23:09:36.131 T:3564675808 DEBUG: Found candidate resolution Windowed
2019-05-11 23:09:36.131 T:3564675808 DEBUG: Not added - < current resolution
2019-05-11 23:09:36.131 T:3564675808 DEBUG: Found candidate resolution 1920x1080 @ 59.94 - Full Screen
2019-05-11 23:09:36.131 T:3564675808 DEBUG: Added to default whitelist
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Found candidate resolution 720x480 @ 60.00 - Full Screen
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Not added - < current resolution
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Found candidate resolution 720x480 @ 59.94 - Full Screen
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Not added - < current resolution
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Found candidate resolution 1280x720 @ 60.00 - Full Screen
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Not added - < current resolution
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Found candidate resolution 1280x720 @ 59.94 - Full Screen
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Not added - < current resolution
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Found candidate resolution 1920x1080 @ 60.00i - Full Screen
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Not added - < current resolution
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Found candidate resolution 1920x1080 @ 59.94i - Full Screen
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Not added - < current resolution
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Found candidate resolution 1920x1080 @ 60.00 - Full Screen
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Added to default whitelist
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Found candidate resolution 1920x1080 @ 59.94 - Full Screen
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Added to default whitelist
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Found candidate resolution 1920x1080 @ 30.00 - Full Screen
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Not added - 25 or 30 refresh rate
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Found candidate resolution 1920x1080 @ 29.97 - Full Screen
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Not added - 25 or 30 refresh rate
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Found candidate resolution 1920x1080 @ 24.00 - Full Screen
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Added to default whitelist
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Found candidate resolution 1920x1080 @ 23.98 - Full Screen
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Added to default whitelist
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Found candidate resolution 3840x2160 @ 30.00 - Full Screen
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Not added - 25 or 30 refresh rate
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Found candidate resolution 3840x2160 @ 29.97 - Full Screen
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Not added - 25 or 30 refresh rate
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Found candidate resolution 3840x2160 @ 25.00 - Full Screen
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Not added - 25 or 30 refresh rate
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Found candidate resolution 3840x2160 @ 24.00 - Full Screen
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Added to default whitelist
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Found candidate resolution 3840x2160 @ 23.98 - Full Screen
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Added to default whitelist
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Found candidate resolution 4096x2160 @ 24.00 - Full Screen
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Added to default whitelist
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Found candidate resolution 4096x2160 @ 23.98 - Full Screen
2019-05-11 23:09:36.132 T:3564675808 DEBUG: Added to default whitelist
2019-05-11 23:09:36.133 T:3564675808 DEBUG: Found candidate resolution 3840x2160 @ 60.00 - Full Screen
2019-05-11 23:09:36.133 T:3564675808 DEBUG: Added to default whitelist
2019-05-11 23:09:36.133 T:3564675808 DEBUG: Found candidate resolution 3840x2160 @ 59.94 - Full Screen
2019-05-11 23:09:36.133 T:3564675808 DEBUG: Added to default whitelist
2019-05-11 23:09:36.133 T:3564675808 DEBUG: Found candidate resolution 3840x2160 @ 60.00 - Full Screen
2019-05-11 23:09:36.133 T:3564675808 DEBUG: Added to default whitelist
2019-05-11 23:09:36.133 T:3564675808 DEBUG: Found candidate resolution 3840x2160 @ 59.94 - Full Screen
2019-05-11 23:09:36.133 T:3564675808 DEBUG: Added to default whitelist
2019-05-11 23:09:36.133 T:3564675808 DEBUG: Trying to find exact refresh rate
2019-05-11 23:09:36.133 T:3564675808 DEBUG: Matched exact whitelisted Resolution 1920x1080 @ 23.98 - Full Screen (28)
2019-05-11 23:09:36.133 T:3564675808 NOTICE: Display resolution ADJUST : 1920x1080 @ 23.98 - Full Screen (28) (weight: 0.000)
I’m not sure if it was intentional that the behavior differ depending on whether or not a whitelist was in place. The new build works perfectly for me as is, since I prefer to run a whitelist anyway.
Please let me know if there is any further testing you would like me to perform to help finalize the solution. I may not have a great deal of availability, but I’m happy to help in any way I can.
Thanks for testing. Yes it is intentional, so that users have a choice.
Awesome, then it looks like this is good to go. Is this change likely to be included in the next patch, or should I make a mental note that I’ll need to re-apply a custom build after the upcoming patch is released?
I can also confirm that this change works well and refresh rate changes as expected when using whitelists .
Thanks for the support !!
Hi, @grahamh. I was playing a 720p/23.976Hz video today, and my Vero 4K+ insisted on playing it at 720p/59.94 whether I had whitelisted that resolution or not. (1080p/23.976 would be the more sensible choice).
I’m not certain if I have a build that should contain this change or not - could you tell me what version number contains it?
Sorry mate, I don’t think Sam’s pulled it yet. I’ve been trying to persuade Kodi to pull it but they don’t like it. Forgot to PR to OSMC but I will do it tomorrow.
Okay, thanks.
Can the modified bin file with the patched resolution code be used safely with the May update of OSMC for people like angry.sardine that just need a quick fix, or will it cause issues because it was built based on an older version? I’m not familiar enough with the underpinnings of Kodi to know whether there are linkages that would cause conflicts between versions.
I can pull it easily enough. No need to PR.
Probably, yes, but the link has expired.