Hi Sam, OSMC May update is not based on the final Kodi 16.1 kodi, at least one patch is missing:
xbmc:master
← DaveTBlake:CuesheetPlaying
opened 06:38PM - 11 Apr 16 UTC
This fixes ticket #16615, a longstanding issue with playing cuesheet. If individ… ual songs from a cuesheet are added to a playlist using JSON then when one of these songs is currently playing `Playlist.GetItems` only ever returns the info for the first song on the cuesheet rather than the actual one playing. See http://trac.kodi.tv/ticket/16615 for full discussion.
The issue does NOT happen when using Playlist.Add on the whole Album object, only individual songs, nor does it happen when the playlist is created using the GUI rather than JSON.
Example JSON API commands, given songs are on a cuesheet (single file)
{"jsonrpc":"2.0","id":1,"method":"Playlist.Clear","params":{"playlistid":0}}
{"jsonrpc":"2.0","id":1,"method":"Playlist.Add","params":{"playlistid":0,"item":{"songid":141}}}
{"jsonrpc":"2.0","id":1,"method":"Playlist.Add","params":{"playlistid":0,"item":{"songid":142}}}
{"jsonrpc":"2.0","id":1,"method":"Playlist.Add","params":{"playlistid":0,"item":{"songid":143}}}
{"jsonrpc":"2.0","id":1,"method":"Player.Open","params":{"item":{"playlistid":0,"position":0}}}
{"jsonrpc":"2.0","id":1,"method":"Player.GetItem","params":{"properties":["album", "albumartist", "artist", "playcount"], "playerid":1}}
In the long run a redesign of playback commands is needed to simplify things. In the meanwhile this modification will enable cuesheet playback to fucntion correctly from remotes and web interfaces to Kodi.
The solution is that when songs are added to the playlist by JSON they need to pass the songid, just as the GUI does, not just the filename as for songs on a cuesheet the filename does not identify the song. This means CFileitem.m_strPath needs to be a virtual file indicating songid.
this patch was merged and included in 16.1 final (also in krypton) however it is missing in your May update for some reason. I confirmed that the patch is included in 16.1 by building from source on my main x64 HTPC and verifying that the issue is fixed. OSMC/May update reports “16.1.RC3” (not final) and the issue that the patch fixed is still present.
Any chance to have OSMC based on Kodi 16.1 Final with all accepted patches?