Samba woes

hi guys Ive bought a new router because my talktalk one is rubbish pluged hdd into router via usb but when I try to add samba shares wih my daughters pi so she can watch her stuff on her pi there is nothing there I have configured the router correct it only picks the router up in upnp devices which she is not happy about because it does not scrape the content I can now see the volume in smb but when I click it it ask me for a username and password and underneath that it says remember for this path can anybody advise thanks