[TESTING] Kodi 18 (Leia) builds for Raspberry Pi

[3rr0r]

Hi,

thanks for your reply. i’ve never said that theese patches improve something or are essential for the proper work of inputstream. Just said there are patches and newer version which are not included in OSMC and inputstream is working with other distros “ootb”.

@sam_nazarko

We only have some limited resources for tracking / building nightlies; so we can’t build every PR or suggestion.

I understand this, but can’t see so many PR or suggestion in the last weeks/months

@sam_nazarko

Of course requests are not forbidden; I was just saying it will come when it’s ready. Hopefully in the next couple of weeks. The nightlies will also resume now as we have fixed some more issues.

Thank you for clarifying this out. Will wait for the next releases, but Amazon and Netflix support is one of the most wanted features in Kodi 18 and still available on other distros and the main reason why i and many more switched to kodi 18

Nevertheless you, GMC and all the other devs did/do a great job. Thanks for that.

[sam_nazarko]

@3rr0r

. Just said there are patches and newer version which are not included in OSMC and inputstream is working with other distros “ootb”.

Those patches are to the LibreELEC build system and are not related to OSMC. They won’t do anything for OSMC. Some of them are also PVR related; rather than inputstream related.

@3rr0r

I understand this, but can’t see so many PR or suggestion in the last weeks/months

I think you might misunderstand the purpose of this thread. The thread is for tracking top-of-tree (Kodi master) + improvements to Raspberry Pi (from newclock5). It’s not for tracking kodi-agile (and neither are Milhouse builds). Neither I or @gmc are Kodi maintainers, so we don’t build and evaluate PR requests for Kodi. We do maintain our downstream patches (rebase + add new ones where necessary) to keep on top of releases.

@3rr0r

Will wait for the next releases, but Amazon and Netflix support is one of the most wanted features in Kodi 18 and still available on other distros and the main reason why i and many more switched to kodi 18

It’s also quite early yet. Again, these are pre-alpha releases.

If LE works for you and you need Netflix + Amazon Video immediately, I suggest you use this. We will add support when we are ready and things are working smoothly on OSMC. That’s looking like a couple of weeks.

[gmc]

Might be a couple more days yet before the next build. There have been lots of changes to the binary addons which are causing build failures. Will need to wait until its fixed upstream. (Or build without addons)

[gmc]

17.8-084, 30 June 2017: Based off OSMC commit (5522094) and newclock5 (ca659cc)

OSMC
Temp remove pvr.hdhomerun, game.libretro.fmsx due to build issue
Temp remove vfs.rar due to build issue

XBMC:
[network] fix CID 1364572 - ensure we’re not leaking the ipv6 test socket (PR:12337, 1 commit, 1 file changed)
[cleanup] Remove HAS_FILESYSTEM (PR:12350, 1 commit, 4 files changed)
Nuke u16string and u32string own implementation (PR:12293, 2 commits, 4 files changed)
[fix][Take II] Nuke ‘libpng warning: iCCP: known incorrect sRGB profile’ warnings and optimize images (PR:12345, 37 commits, 1207 files changed)
Rework OS screen saver handling (PR:12342, 10 commits, 20 files changed)
[cleanup] Cleanup system.h unused defines (PR:12347, 1 commit, 1 file changed)
[vfs] change addon interface to new C++ style (PR:12356, 1 commit, 18 files changed)
[fix][pictures] CID 77607: prevent buffer overflow (PR:12369, 1 commit, 1 file changed)
DBus refactoring (PR:12371, 13 commits, 16 files changed)

Includes latest addons: inputstream.adaptive (a1d37ac5), inputstream.rtmp (6db3697a), peripheral.joystick (f5538d25, +1), pvr.argustv (b281e04f), pvr.demo (ffee02b8), pvr.dvblink (6d42eae1), pvr.dvbviewer (a5db9ddb), pvr.filmon (300c595e), pvr.hdhomerun (9073b99b), pvr.hts (2651886f), pvr.iptvsimple (dbf6011e), pvr.mediaportal.tvserver (07d73f3a), pvr.mythtv (fbb7e561), pvr.nextpvr (239dbef3), pvr.njoy (4785afd2), pvr.octonet (9bbd7cf3), pvr.pctv (f61e2541), pvr.stalker (151e3d3f), pvr.vbox (df9efea4), pvr.vdr.vnsi (40dc17d0), pvr.vuplus (83a729ea), pvr.wmc (93cebfc7)

[gmc]

HDhomerun is building again, Haven’t tested it yet but I’ve fixed the build issue and included in the latest build.

[gmc]

17.8-085, 15 July 2017: Based off OSMC commit (05c3658c) and newclock5 (f71c5e4c53)

OSMC:
Temp remove audo decoders due to build errors: audiodecoder.modplug audiodecoder.sidplay audiodecoder.nosefart audiodecoder.snesapu
Re-add pvr.hdhomerun

XBMC:
VideoPlayer: cleanup / fix RenderManager (PR:12471, 1 commit, 2 files changed)
[addons] Fix compiler warning: xbmc/xbmc/addons/RepositoryUpdater.h: (PR:12468, 1 commit, 1 file changed)
[cleanup] Prefer ‘override’ usage (PR:12466, 3 commits, 3 files changed)
Support more yuv420p bitwidths for direct rendering on Linux (PR:12479, 2 commits, 7 files changed)
VideoPlayer: vaapi - fix c/p error (3fb3d0b8)
VideoPlayer: vdpau - fix c/p error (12035632)
InputstreamAddon::OpenStream / AddonVideoCodec::VideoBuffers cleanup (#12469) (7279ca5f)
VideoPayer: fix VideoBufferSysMem (PR:12463, 1 commit, 5 files changed)
[addons] change OnEnabled and OnDisabled to use AddonPtr (PR:12444, 1 commit, 3 files changed)
ADD: [droid] network stuff via api (PR:12243, 2 commits, 10 files changed)
Modernize CEventGroup (PR:12458, 1 commit, 5 files changed)
[cmake] use normalized to lower case CORE_PLATFORM_NAME in conditionals (PR:12465, 1 commit, 2 files changed)
[PVR] Do not mark in progress recordings as watched. (PR:12445, 1 commit, 3 files changed)
Fix compiler warnings: ‘foo’ has virtual functions but non-virtual destructor (PR:12446, 1 commit, 9 files changed)
Remove casts not required anymore (PR:12455, 1 commit, 1 file changed)
added: ability to inspect add-on dependencies prior to installation (PR:12242, 1 commit, 6 files changed)
Fix missing member initialization (PR:12459, 3 commits, 3 files changed)
Reorganize FindVAAPI.cmake (PR:12456, 1 commit, 1 file changed)
VideoPlayer updates (PR:12212, 98 commits, 203 files changed)
[cleanup] silence compiler warnings (PR:12443, 3 commits, 10 files changed)
revert explicitly defaulted constructor (PR:12448, 1 commit, 1 file changed)
[fix] coverity issues (PR:12451, 7 commits, 8 files changed)
Fix broken virtual keyboard when using a controller (PR:12439, 1 commit, 1 file changed)

pvr.octonet:
Added minimalistic support for PVR Addon API 5.3.0 (a77cf111)

inputstream.adaptive:
OpenStream / ReleaseFrameBuffer (12238808)
Merge branch ‘master_new’ of GitHub - xbmc/inputstream.adaptive: kodi inputstream addon for several manifest types into master_new (e701ecf2)
ReleaseBuffer / drain implementation (bceb9f6b)
ISM pssh / update samle description / get extra-data on startup (78d63206)
Merge branch ‘master_new’ of GitHub - xbmc/inputstream.adaptive: kodi inputstream addon for several manifest types into master_new (b348aa2b)
Don’t reuse ref vars → assignement is copied if ref is set (e2882fac)
Merge branch ‘master_new’ of GitHub - xbmc/inputstream.adaptive: kodi inputstream addon for several manifest types into master_new (a43d1ee9)

newclock5:

New commits in this build:
VideoPlayer: set some process infos for the case get_format gets not called (f71c5e4c)
MMAL: Fixup format/alignment for retroplayer (d8ac8318)
VideoPlayer: cleanup / fix RenderManager (c274f3ef)
VideoPlayer: flush renderer on channel switch (f8332677)
VideoPlayer: rework speed and tempo (055b360a)
squash (23e4bf77)
squash (019b9ebf)
fixup: Add back SAND formats (08f7bc48)

Commits no longer in build:
VideoPlayer: cleanup / fix RenderManager (c274f3ef)
squash (23e4bf77)
squash (019b9ebf)
AddonVideoCodec: Switch to using CVideoBufferManager (3e30584e)
MMAL: Fixup format/alignement for retroplayer (a8399fa6)
fixup: Add back SAND formats (08f7bc48)
follow ffmpeg docs for avio_alloc_context (8c3117fe)
VideoPlayer: vdpau - add runtime check (41722f21)
VideoPlayer: move video queue level to ProcessInfo (ebaee8f9)
VideoPlayer: create a state for gui/video render (af10b720)
VideoPlayer: add some logging for audio (728521de)
VideoPlayer: rename and move YuvImage (d0daa57c)
VideoPlayer: drop CodecUtils::Allocat/FreePicture (2c0c8c92)
VideoPlayer: cleanup CodecUtils (556204ad)
VideoPlayer: add video buffers (9d791a37)
VideoPlayer: drop render formats (3c519963)
VideoPlayer: change videoPicture to const (b870f3fa)
VideoPlayer: OSX adapt to video buffers (2a4f3e07)
VideoPlayer: drop PreInit, move supported pix formats to PprocessInfo (1a24dc26)
RP compile error (b99cdf21)
VideoPlayer: vaapi - adapt to video buffers (96be6b19)
VideoPlayer: vdpau - adapt to VB (21ad4b75)
VideoPlayer: Fix missing #include (a1d1f1a6)
VideoPlayer: Fix missing virtual destructors (e84a293a)
RetroPlayer: Update for video buffers (e5d09fbb)
RetroPlayer: Fix spelling error (65d82155)
VideoPlayer: fix wrong values in DataCacheCore (2efa6a84)
VideoPlayer: drop some obsolete casts, squash to videobuffers (44d5434a)
RetroPlayer: Fix RPi after videobuffers update (fef4d399)
adapt windows (6c2963c4)
cosmetic changes (7fd3249c)
VideoBuffer: Avoid unsafe race when resetting pool (a737e102)
VideoBuffers: Use YuvImage::MAX_PLANES (2d6c4c9b)
VideoBuffer: Fix unsafe use of atomics (e50aea7f)
VideoPlayer: have platforms register their laform specific codecs into factory (3f4674d6)
VideoPlayer: make AddonVideoCodec compile - fix me (3ce0dd5b)
VideoPlayer: vaapi - factor out egl interop (edea65f8)
VideoPlayer: vdpau - add register codec (a9863824)
X11: register vdpau and vaapi (4dc62b37)
omxplayer: Move GetLevel to ProcessInfo (63d93043)
OMXPlayerVideo: fixups (ded3f207)
DVDVideoCodecFFmpeg: Clear videoBuffer after release (65f03f74)
RenderManager: Protect against null videoBuffer (8adde02a)
aml / linuxgles adaption (ad387c9e)
RenderManager: MMALRenderer should always be used when available (a51c4f94)
RendererVAAPIGLES: Make it compile (843b8dbf)
LinuxRendererGLES: Make it compile (1ca7f53c)
MMAL: Fixups (997d93cc)
MMAL: Remove unused decoder parameter (36098845)
PixelConverterRBP: Fixup (03f51ab4)
MMAL: Move to MMAL namespace (d7bef4a4)
MMAL: Use CVideoBuffer and IVideoBufferPool as bases for MMAL (0e2050d5)
MMAL: Register HW codecs from windowing (589dc9bf)
VideoPlayer: osx - register vtb codec (bcda2a89)
VideoPlayer: introduce factory for renderers (19952c0b)
VideoPlayer: add renderFormats for LinuxRendererGL (7eed850c)
Move VAAPI display creation to WinSystem (a32a60c0)
VideoPlayer: vaapi - move egl interop check to renderer (fd776984)
squash windows register (8e2b9059)
squash osx register (db90cf98)
AMLVideoBufferPool (104d9bf7)
videoBuffer continued… (7f3530f6)
videoBuffer compiles… (86f3f0c5)
Render registration (5f153511)
Remove Bypass / Render videoBuffer in LinuxRendererGLES (018c4cc7)
Remove unused pbo / set VideoBuffer::loaded (9872d23d)
Fix LinuxRendererGLES / Register AMLCodec (90792f6a)
Fix refcounting (7b23d5fb)
VideoPlayer: register ProcessInfo (d69e4745)
MMAL: Pool should be created with unknown encoding type (f5a0d17b)
MMALRender: Specified aligned width/height should be forced (982b96ca)
MMAL: Register hardware renderer (2d37e0ca)
Android MediaCodec:: VideoBuffer implementation (db58f53b)
AudioDecoderHW Registration / DVDCodecAudioAndroidMediaCodec (a6bee13d)
Fix FactoryCodec::Audio / MediaCodecOES (8469d8e5)
Register LinuxRenderGLES / Fix MediaCodec Non-Surface (2dd077bd)
VideoPlayer: ios - adapt to changes (ff9abcc5)
RBP: Register ProcessInfo (efa87f05)
CVideoBufferManager: Add critical section (3ac4b7ec)
fixup! MMALRender: Specified aligned width/height should be forced (1de4c466)
MMAL: Move mmal buffer initialisation to update function (3b81a202)
RP: fix compile (75235e00)
VideoPlayer: make VideoBufferManager non copyable (603c314c)
VideoPlayer: vdpau - register renderer (1ac6be87)
VideoPlayer: vtbgl - register renderer (947937b1)
VideoPlayer: LinuxRendererGL - clear backbuffer if render failed (83cc6a9a)
VideoPlayer: interface cleanups, override (f2d881dd)
windows: cosmetics, whitepaces (cefdb32e)
windows: register ProcessInfo (0004d41c)
ProcessInfo: Fix compiler warning (1e3de0e8)
AddonVideoCodec: Switch to using CVideoBufferManager (01cf72a5)

Includes latest addons: inputstream.adaptive (a43d1ee9, +4), inputstream.rtmp (39d7979a), peripheral.joystick (b4331919), pvr.argustv (4e8c838b), pvr.demo (f67dff13), pvr.dvblink (640629ca), pvr.dvbviewer (9faf2413), pvr.filmon (1c9d2ebe), pvr.hdhomerun (48868e44), pvr.hts (1653a3a7), pvr.iptvsimple (8ccf85cc), pvr.mediaportal.tvserver (642f9af1), pvr.mythtv (46748fcd), pvr.nextpvr (03a3b714), pvr.njoy (79e8e653), pvr.octonet (a77cf111), pvr.pctv (00b76689), pvr.stalker (9e28f125), pvr.vbox (12d629c4), pvr.vdr.vnsi (3473225b), pvr.vuplus (55e4f5f9), pvr.wmc (1d655540)

[gmc]

17.8-086, 17 July 2017: Based off OSMC commit (a64a19abf9) and newclock5 (78380ed)

OSMC:
Temp remove audo decoders due to build errors: audiodecoder.modplug audiodecoder.sidplay audiodecoder.nosefart audiodecoder.snesapu

XBMC:
[cmake] cleanup FindOpenGLES.cmake (PR:12461, 3 commits, 3 files changed)
VideoPlayer: fixes (PR:12491, 2 commits, 5 files changed)
fix python local weekday name (PR:8478, 1 commit, 1 file changed)
Fix endless loop when opening streams with missing information (PR:12483, 1 commit, 1 file changed)
Fix AddonVideoCodec plane swap (PR:12494, 1 commit, 3 files changed)
Log filter graph only when video component logging is enabled (PR:12496, 1 commit, 1 file changed)
Change CVideoSync stop flag from atomic bool to CEvent (PR:12485, 1 commit, 21 files changed)
VideoPlayer: only set yadif filter for interlaced material (PR:12498, 1 commit, 1 file changed)
VideoPlayer: fix for stillframes (vaapi) (PR:12499, 2 commits, 2 files changed)
[depends][win32] Hopefully fix a python crash (PR:12502, 1 commit, 2 files changed)
[depends][win32] Hopefully fix a dnssd crash (PR:12501, 1 commit, 2 files changed)
RetroPlayer: Remove dependency on IPlayer interface (PR:12493, 1 commit, 3 files changed)

newclock5:

New commits in this build:
MMAL: Fixup after planeOffsets change (78380ed4)

Includes latest addons: inputstream.adaptive (a43d1ee9, +4), inputstream.rtmp (39d7979a), peripheral.joystick (6e070435, +3), pvr.argustv (4e8c838b), pvr.demo (f67dff13), pvr.dvblink (640629ca), pvr.dvbviewer (9faf2413), pvr.filmon (1c9d2ebe), pvr.hdhomerun (48868e44), pvr.hts (1653a3a7), pvr.iptvsimple (8ccf85cc), pvr.mediaportal.tvserver (642f9af1), pvr.mythtv (46748fcd), pvr.nextpvr (03a3b714), pvr.njoy (79e8e653), pvr.octonet (a77cf111), pvr.pctv (00b76689), pvr.stalker (9e28f125), pvr.vbox (12d629c4), pvr.vdr.vnsi (3473225b), pvr.vuplus (55e4f5f9), pvr.wmc (1d655540)

[mts]

Hi @gmc, I’m trying to build my own version of the leia package because I’d like to use an own fork of newclock5 with some additional commits merged in. I tried to run make rbpc in mediacenter-next-xbmc of the gmc-18 branch from GitHub - StormTrooper/osmc: OSMC (Open Source Media Center) is a free and open source media center distribution but I’m running into problems with patches beeing rejected, specifically rbp-003 and rbp-090. There seem to be some incompatibilities with the current newclock5 which seems strange to me. Am I using the wrong repo/branch maybe, or could there be anything else I’m missing?

[lilldeck]

@mts they change https://github.com/xbmc/xbmc/pull/12021 so you will have to update those patches and change a few lines i build.sh befor it compiles so wait for gmc to update his github

[mts]

Which he has just done apparently. Excellent, the patches run through now. However, now I’m runnning into a dependency problem with ffmpeg/libfmt.

Let me know if the branch isn’t actually supposed to build right now. In that case I’ll shut up about my build errors and just wait

-- FFmpeg 3.3 not found, falling back to internal build
CMake Error at /usr/share/cmake-3.6/Modules/FindPackageHandleStandardArgs.cmake:148 (message):
  Could NOT find Fmt (missing: FMT_LIBRARY FMT_INCLUDE_DIR) (found version
  "3.0.1")
Call Stack (most recent call first):
  /usr/share/cmake-3.6/Modules/FindPackageHandleStandardArgs.cmake:388 (_FPHSA_FAILURE_MESSAGE)
  cmake/modules/FindFmt.cmake:41 (find_package_handle_standard_args)
  cmake/scripts/common/Macros.cmake:336 (find_package)
  CMakeLists.txt:164 (core_require_dep)


-- Configuring incomplete, errors occurred!
See also "/mnt/package/mediacenter-next-osmc/src/xbmc-86cce42c15313660378661affbdd016705199cf0/CMakeFiles/CMakeOutput.log".
See also "/mnt/package/mediacenter-next-osmc/src/xbmc-86cce42c15313660378661affbdd016705199cf0/CMakeFiles/CMakeError.log".
make: *** No targets specified and no makefile found.  Stop.
Build failed!

[gmc]

I’ve updated the code for the changes and run a build for the rbp2 which is now working.

[gmc]

There is no debian or osmc libraries yet for libfmt so you will need to build your own.
@sam_nazarko We should probably build this.

https://github.com/xbmc/xbmc/blob/master/docs/README.linux

[NOTICE] libfmt / libfmt3-dev all Linux distributions.
Kodi now requires libfmt which is not available in Ubuntu repositories at this time.
We supply a Makefile in tools/depends/target/libfmt
to make it easy to install into /usr/local.
$ make -C tools/depends/target/libfmt PREFIX=/usr/local

chroot into /opt/osmc-tc/armv7-toolchain-osmc/ and run the above.

Let me know if you get stuck. I can always post the version I built a while back.

The branch builds however as you have found there are a few manual tweaks required to get it completed.
Note to self: I really need to document them as I have the same issues when I need to purge the toolchain

[godinperson]

Hey guys, I have two Kodi on Raspberry Pi 3. I’ve got one that crashes every seconds since 17.8-084 while the other one works perfectly fine. Any idea why?

[gmc]

Can only guess without debug logs.

[godinperson]

Yep, I checked after writing my post.

The last line was:
Window Translator: Can’t find window MyMusicFiles

[gmc]

17.8-087, 20 July 2017: Based off OSMC commit (ae2c775c1) and newclock5 (f07c935)

OSMC:
Temp remove audo decoders due to build errors: audiodecoder.modplug audiodecoder.sidplay audiodecoder.nosefart audiodecoder.snesapu

XBMC:
[mediamanager] Use meta data provided disc names and add Blu-ray detection. (PR:12488, 5 commits, 5 files changed)
[swig] Partially revert 71151fe2b9. Causes problems with swig < 3.0 (PR:12490, 1 commit, 20 files changed)
VideoPlayer: reset dataCacheCore when new player is created (PR:12505, 1 commit, 3 files changed)
added: SortByDateAdded in Music Video title node (PR:12495, 1 commit, 1 file changed)
exit GIL when calling into GUI (PR:12504, 1 commit, 6 files changed)
[cmake][linux] Fix CodeCoverage.cmake path (PR:12509, 1 commit, 1 file changed)

inputstream.adaptive:
Remove backslashes from b64 source data (6a736970)
Fix ism / widevine pssh generation (900af93e)
Merge branch ‘master’ of GitHub - xbmc/inputstream.adaptive: kodi inputstream addon for several manifest types (07d4979e)
allow jumps in smoothstream timeline (bcec87b9)
Merge branch ‘master’ of GitHub - xbmc/inputstream.adaptive: kodi inputstream addon for several manifest types (af04e438)

peripheral.joystick:
[settings] Use “list” instead of “spinner” type (PR:119, 1 commit, 1 file changed)

pvr.mythtv:
sync cppmyth config (3417026f)

Includes latest addons: inputstream.adaptive (af04e438, +7), inputstream.rtmp (39d7979a), peripheral.joystick (6e18bc74, +4), pvr.argustv (4e8c838b), pvr.demo (f67dff13), pvr.dvblink (640629ca), pvr.dvbviewer (9faf2413), pvr.filmon (1c9d2ebe), pvr.hdhomerun (48868e44), pvr.hts (1653a3a7), pvr.iptvsimple (8ccf85cc), pvr.mediaportal.tvserver (642f9af1), pvr.mythtv (3417026f, +1), pvr.nextpvr (03a3b714), pvr.njoy (79e8e653), pvr.octonet (a77cf111), pvr.pctv (00b76689), pvr.stalker (9e28f125), pvr.vbox (12d629c4), pvr.vdr.vnsi (3473225b), pvr.vuplus (55e4f5f9), pvr.wmc (1d655540)

[mts]

Thanks gmc that helped. I also needed to apt-get install swig in the chroot. It’s now happily building the deps, hoping it’ll run through. I’m building on the pi so it’s going to take a while until I find that out.

Just in case it fails, can I somehow restart the build without having it download the sources and build everything from the start like make rbp2 does?

edit: swig, not twig

[gmc]

Ah yes, forgot to mention you need swig 3 otherwise it will fail about half way.
I used to build on the pi. Take about 6 hours with all the addons.
Now on the vero 4k, its down to 2 hours
If it fails you will unfortunately have to start over.

There was also a binary addon that failed and git complained about missing username/email. Not sure if its still the case but you might want to also do:

git config user.name="John Doe" 
git config user.email=johndoe@example.com```

[mts]

Installed swig3 and set the git config.

I’m getting until after ffmpeg has been built sucessfully, then it stops with no reason apparent to me:

INSTALL libavutil/libavutil.pc
[100%] Completed 'ffmpeg'
[100%] Built target ffmpeg
[  8%] Performing install step for 'ffmpeg'
[100%] Built target ffmpeg
Install the project...
-- Install configuration: "Release"
Done
[  8%] Completed 'ffmpeg'
[  8%] Built target ffmpeg
Makefile:138: recipe for target 'all' failed
make: *** [all] Error 2
Build failed!
Makefile:8: recipe for target 'rbp2' failed
make: *** [rbp2] Error 1
make: Leaving directory '/mnt/package/mediacenter-next-osmc'
Makefile:8: recipe for target 'rbp2' failed
make: *** [rbp2] Error 2

Would any log output help? Not sure where to look.

edit: found it in CMakeError.log, it can’t find pthreads
http://termbin.com/08w9

edit2: probably not related to pthreads at all -
https://gitlab.kitware.com/cmake/cmake/issues/16540#note_215187

[gmc]

Best would be to output the build to a log file and post that.
Are you building it on a Rpi2? Running osmc?

Ive checked a build I ran a few hours ago and not getting any of those errors.