[TESTING] Kodi 18 (Leia) builds for Raspberry Pi

fzinken · 31 December 2017 16:42

Confirmed, downgrade to Krypton makes hifiberry appear

sam_nazarko · 31 December 2017 17:56

I think that the issue is caused by AudioEngine changes in Kodi v18. It looks like the sound implementation is now coupled with the windowing system. On Pi, it’s clear that PISink is brought up, but ALSASink doesn’t appear to be.

If that is the issue, then this should probably do the trick:

From da5569f1171172f61ac5274bbde26dd43c636039 Mon Sep 17 00:00:00 2001
From: Sam Nazarko <email@samnazarko.co.uk>
Date: Sun, 31 Dec 2017 17:08:42 +0000
Subject: [PATCH] CWinSystemRpi: ensure that we register the ALSA sink as well
 as PiSink. This is needed for external DACs

Signed-off-by: Sam Nazarko <email@samnazarko.co.uk>
---
 xbmc/windowing/rpi/WinSystemRpi.cpp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/xbmc/windowing/rpi/WinSystemRpi.cpp b/xbmc/windowing/rpi/WinSystemRpi.cpp
index 9e7f8bd..ac1618c 100644
--- a/xbmc/windowing/rpi/WinSystemRpi.cpp
+++ b/xbmc/windowing/rpi/WinSystemRpi.cpp
@@ -35,6 +35,7 @@
 #include "../WinEventsLinux.h"
 #include "cores/AudioEngine/AESinkFactory.h"
 #include "cores/AudioEngine/Sinks/AESinkPi.h"
+#include "cores/AudioEngine/Sinks/AESinkALSA.h"
 
 #include <EGL/egl.h>
 #include <EGL/eglplatform.h>
@@ -55,6 +56,7 @@ CWinSystemRpi::CWinSystemRpi()
   m_winEvents.reset(new CWinEventsLinux());
   AE::CAESinkFactory::ClearSinks();
   CAESinkPi::Register();
+  CAESinkALSA::Register();
 }
 
 CWinSystemRpi::~CWinSystemRpi()
-- 
2.7.4

Sam

gmc · 31 December 2017 18:41

Thanks will add this into the next build.

gb160 · 1 January 2018 07:50

Im glad it sounds like you’ve got to the bottom of the issue chaps…Happy New Year to all of the OSMC devs, and many thanks for the hard work you guys/girls? put in.

grainger · 1 January 2018 22:19

Ripper Rita!

Installed latest update 154

DAC’s working again

Thanks

Happy New Year

sam_nazarko · 2 January 2018 11:29

Thanks for confirming.

Sam

gb160 · 2 January 2018 12:07

FYI loopback audio device is still missing in this version.
I’ll stick with 17.8.143 for the time being.

sam_nazarko · 2 January 2018 12:14

Is the loopback audio device enumerated if you run aplay -l (need alsa-utils installed)?

gb160 · 2 January 2018 12:16

Im pretty sure it is Sam, I’ll update again and report back.

gb160 · 2 January 2018 12:31

Indeed it does Sam:

Blockquote
osmc@osmc:~$ aplay -l
**** List of PLAYBACK Hardware Devices ****
card 0: Loopback [Loopback], device 0: Loopback PCM [Loopback PCM]
Subdevices: 8/8
Subdevice #0: subdevice #0
Subdevice #1: subdevice #1
Subdevice #2: subdevice #2
Subdevice #3: subdevice #3
Subdevice #4: subdevice #4
Subdevice #5: subdevice #5
Subdevice #6: subdevice #6
Subdevice #7: subdevice #7
card 0: Loopback [Loopback], device 1: Loopback PCM [Loopback PCM]
Subdevices: 8/8
Subdevice #0: subdevice #0
Subdevice #1: subdevice #1
Subdevice #2: subdevice #2
Subdevice #3: subdevice #3
Subdevice #4: subdevice #4
Subdevice #5: subdevice #5
Subdevice #6: subdevice #6
Subdevice #7: subdevice #7
card 1: ALSA [bcm2835 ALSA], device 0: bcm2835 ALSA [bcm2835 ALSA]
Subdevices: 8/8
Subdevice #0: subdevice #0
Subdevice #1: subdevice #1
Subdevice #2: subdevice #2
Subdevice #3: subdevice #3
Subdevice #4: subdevice #4
Subdevice #5: subdevice #5
Subdevice #6: subdevice #6
Subdevice #7: subdevice #7
card 1: ALSA [bcm2835 ALSA], device 1: bcm2835 ALSA [bcm2835 IEC958/HDMI]
Subdevices: 1/1
Subdevice #0: subdevice #0

Just no way to select it in the System/Audio settings.
Ive tested the device via aplay and can successfully send audio to it and its working fine.

sam_nazarko · 2 January 2018 12:48

This may be related to a change that drops ‘null sinks’ in Kodi.

Sam

gb160 · 2 January 2018 12:54

So I take it thats out of your hands then?

Not the end of the world, i’ll just have to stick with 17.8.143 then, that version has all the functionality I need working just fine.

gmc · 2 January 2018 13:05

Interesting. Must be from:
PiSink: Treat default as HDMI (fbff01f31)

The latest patch from @sam_nazarko is not included yet.

[PATCH] CWinSystemRpi: ensure that we register the ALSA sink as well as PiSink.

Nightly build which includes this just finished so will upload it shortly.

grainger · 2 January 2018 13:18

Oh… I grabbed the deb file from
http://ftp.fau.de/osmc/osmc/download/dev/gmc-18/

rbp2-mediacenter-osmc.deb 1/1/18

seemed to do the trick

gmc · 2 January 2018 14:42

Ah ok. That explains it. That file does contain the patch. Its finished building but I haven’t moved it into aptly yet or posted the build notes. You are too fast

Rickt1962 · 2 January 2018 17:21

The original is not that easy to follow

To try this:
1.Login via the command line94
2.Edit the file /etc/apt/sources.list
3.Add the following line: deb http://apt.osmc.tv jessie-devel main
4.Check for updates via My OSMC → Updater.

edit the file sudo nano /etc/apt/sources.list because /etc/apt/sources.list errors out
Check for updates via My Osmc On the Raspberry Pi go into OSMC the updates error out.

ooZee · 2 January 2018 17:29

What is the error?

ActionA · 2 January 2018 17:33

sam_nazarko · 2 January 2018 17:40

You still haven’t updated to Debian Stretch.
I’m not sure how we can make it clearer but if you don’t do this, you won’t be able to update

gmc · 2 January 2018 18:53

17.8-154, 2 Jan 2018: Based off OSMC commit (ab6624ae) and newclock5 (fbff01f3d)

OSMC:
ASLA sink for Pi (430721)
Add missing patch Fix crash on skin reload (ee2a6dfa)
Add missing patch Fix setting loss when rebooting from Kodi (e7b0bfd)