In my experience as a coder, once a solution is found, all the time it took becomes immaterial - for me the fear of not being able to solve the issue (which has happened a few times in my career) was always far worse.
Do you think a toggle option can be introduced into osmc (presumably manual, unless it’s possible to detect from metadata that the colourspace is actually restricted when set to full), or is resetting the flag on the affected files the way forward?
You’re not wrong about it being pricey - the greatest cost perhaps being Windows 10 as a requirement.
My main platform is Linux, with Windows 7, heavily modified (e.g. telemetry backports removed and other insidious data leakage blocked) as a fall back, on a dual boot PC.
Win7 is needed also for .net coding, as Mono isn’t quite there yet, and my swiss-army knife tool of choice, RegexBuddy.
The clips in question are all incorrectly flagged as Full range. I didn’t find any 0-15 values in those clips. GoPro clips can be true full range (0-255).
To resolve this permanently, Amlogic code needs to be fixed. YUV-RGB conversion doesn’t seem to be correct when full range flag is detected. Can’t say whether the conversion matrix used itself is wrong or not.
It needs to be corrected in the SPS NAL units of the HEVC bitstream.
I’ve been reading up on this, and had been expecting, as you confirmed, that the colourspace flag setting would be repeated throughout the stream (although there seems to be some contension over this on some forums).
It’s a shame there’s no trial version of HDRmaster.
I tried setting the range in mkv header using mkvtoolnix - Header editor. It didn’t work. I think Kodi ignores header values (am not sure of this). I remember another discussion on aspect ratio in header being ignored.
Did you have any luck with introducing a switch to force a file to playback ignoring the SPS NAL values, to overcome incorrectly set colourspace range info?
I’ve still not found a tool to adjust the values in the files them selves (i.e. the approach @wesk05 took with the test files).
A couple of weeks ago you commented ‘I downloaded your clips with incorrect black levels and changed the range to limited.’ I tested the clips you provided at the time, and confirmed everything looked good.
As I recall, to convert the incorrect colorspace information by setting the SPS NAL units of the HEVC bitstream, you used some expensive commercial software from hdr.avtop.com, which I don’t have access to.
I also recall some discussion regarding an alternative option of completely re-encoding an affected file.
I’ve been investigating a way to do this using ffmpeg at the command line, specifically using swscale / sws_setColorspace, but not found a solution as yet.
Is there a simpler method using Handbrake?
Whilst re-encoding isn’t practical as an overall solution (I have far too many affected files), I’d like to try this on a few as it looks like @sam_nazarko’s Vero 4K fix is still some way off.
I don’t think you will be able to do this with Handbrake. The one method that could possibly work is using the NVEnc Stream Patcher. I haven’t tried it personally. You will have to demux the bitstream. So the process is not going to be quick.
I know you’re incredibly busy, but could you give me an indication whether the colourspace issue is likely to ever be fixed (indeed, is it unfixable)?
I’m asking as we’re three months down the line, and I’m wondering if it’s time to look for alternative hardware.
I still have no idea why my collection of films has so many encoded in a non-standard manner - nobody else seems affected (certainly no-one on this thread has mentioned the issue).