Have you considered my point, though? I’m not sure I understand the logic of it but on other platforms and on OSMC atm users will not get, say, 576p when their GUI is 1080p and there’s no whitelist. Just saying if we change that users with other devices and our users that have never dabbled with a whitelist could get confused.
@tanio99 Yeah, I have to agree with Graham on this one - if there’s no whitelist you don’t want to switch to a lower output resolution. So if the desktop UI is 1080p, you don’t want to be switching to 720p, 576p or 480p.
At the risk of expanding the scope here, if you are tinkering with non-whitelist logic, you might also consider allowing it to switch resolution up even there’s no exact resolution match. For example, if the video is 2560x1440, it should probably upscale that to 2160p instead of downscaling to 1080p (which is what it does at the moment). And keep an eye on what happens if there’s a match in only one direction, e.g. if the video is something like 3840x1636, and on weird cases like a video in portrait orientation.
You’re both right. I didn’t consider that. So it needs a more sophisticated solution.
Isn’t that something that should be implemented by the Kodi devs?
I think so. We don’t want to go too wild with whitelisting downstream.
Something we could work on for Kodi v22.
If by that you mean that you’ve managed to get 1080p/25fps videos playing smoothly with the output resolution set to 1080p/50Hz, that’s something I’d very much like to test.
This will be in the next update and is in staging.
I did initially plan to only get this fix from @tanio99 in for v21 but as there were a few other issues to clean up I plan to do another build to roll things up.
Do give it a go.
Cheers
Sam
So, @grahamh - you remember that work you did on deinterlacing of VC-1 videos a while back? You got the cadence detection on the Auto-select option working very nicely, but in the end you had to make Deinterlace the default, because the Auto-select option gave jerky playback on frame-interlaced material output at 50Hz. (And the field-interlaced sections have to be output at 50Hz).
If 25fps stuff can finally be output at 50Hz without any jerkiness problems, that probably means that it’s now to safe to make Auto-select the default option for 1080i/50 VC-1 videos. Maybe you should change that?
(If it were me I would keep Deinterlace as the default for 1080i/60 VC-1 though).
It still does. Planet Earth is a stutterfest with that option. I think this latest tweak was aimed at h264 which what the OP uploaded for us.
Running a test build that contains Tanio’s changes, that clip played smoothly five times in a row, with deinterlacing set to Auto-select and output at 50Hz. It’s always possible the sixth time would have stuttered, I guess! My 60Hz test clips didn’t look so good, though.
@sam_nazarko - does today’s software update contain this change?
Yes.