Changing / improving OSMC skin

General Discussion
63

They’re probably in another group control in one of the two dialogs/windows which adds a coordinate offset from the left.

I’d recommend you get familiar with the skinning wiki over at the Kodi forum: https://kodi.wiki/view/Skinning_Manual It’s quite huge, but comprehensive and very detailed. When I started working on the skin, these smaller things annoyed me a lot, but you’ll get more and more into reading the xml files without issues. Some digging into it is required though and I can’t be of much help as I don’t see what you’re doing all the time. :wink:

1 Like
64

Here you go: https://github.com/Ch1llb0/skin.osmc/tree/v18.0.1

65

thanks.

im still gonna work twards the clickable plot.

i made some more changes to the DialogVideoInfo.xml

removed redundant audio/video info found in the mediaflags
adjusted the plot window for maximum viewing with large font, also made the plot auto center vertically, so the area doesnt look bare with a smaller plot.

also changed the behavior of the refresh button, so it refreshes the title directly from the nfo file in the folder.

IMG_5469
IMG_54693804×2142 1.56 MB

IMG_5470
IMG_54703633×2068 1.56 MB

IMG_5471
IMG_54713675×2081 1.25 MB

67

im seeing a issue when sitting idle for a few mins. on the dialogvideoinfo page the screen goes dim, and nothing brings it back except a skin refresh or reboot

69

yep, found it. all good now

70

can you tell me where to find the control for the location of the circled text?

IMG_5489
IMG_54894019×625 1.13 MB

72

It should be in the DialogVideoInfo.xml in line 54.

75

perfect, thank you! can’t believe i missed that one…

here is my latest Mod:

IMG_5490
IMG_54903305×1857 1.79 MB

76

is it possible to pull the Atmos, DTSX tag from a file during playback?

i am using:

<variable name="VideoPlayerAudioCodec">
	<value condition="String.IsEqual(VideoPlayer.AudioCodec,aac) |String.IsEqual(VideoPlayer.AudioCodec,aac_latm)">AAC</value>
	<value condition="String.IsEqual(VideoPlayer.AudioCodec,ac3)">Dolby Digital</value>
	<value condition="String.IsEqual(VideoPlayer.AudioCodec,aif) | String.IsEqual(VideoPlayer.AudioCodec,aiff)">AIFF</value>
	<value condition="String.IsEqual(VideoPlayer.AudioCodec,alac)">Apple</value>
	<value condition="String.IsEqual(VideoPlayer.AudioCodec,cdda)">Audio-CD</value>
	<value condition="String.IsEqual(VideoPlayer.AudioCodec,dca) | String.IsEqual(VideoPlayer.AudioCodec,dts)">DTS</value>
	<value condition="String.IsEqual(VideoPlayer.AudioCodec,dolbydigital)">Dolby Digital</value>
	<value condition="String.StartsWith(VideoPlayer.AudioCodec,dsd)">DSD</value>
	<value condition="String.IsEqual(VideoPlayer.AudioCodec,dtshd_hra)">DTS-HD HRA</value>
	<value condition="String.IsEqual(VideoPlayer.AudioCodec,dtshd_ma) | String.IsEqual(VideoPlayer.AudioCodec,dtsma)">DTS-HD MA</value>
	<value condition="String.IsEqual(VideoPlayer.AudioCodec,eac3)">Dolby Digital+</value>
	<value condition="String.IsEqual(VideoPlayer.AudioCodec,mp3float)">MP3</value>
	<value condition="String.IsEqual(VideoPlayer.AudioCodec,opus)">Opus</value>
	<value condition="String.IsEqual(VideoPlayer.AudioCodec,pcm) | String.IsEqual(VideoPlayer.AudioCodec,pcm_bluray) | String.IsEqual(VideoPlayer.AudioCodec,pcm_s16le) | String.IsEqual(VideoPlayer.AudioCodec,pcm_s24le)">PCM</value>
	<value condition="String.IsEqual(VideoPlayer.AudioCodec,truehd)">Dolby TrueHD</value>
	<value condition="String.IsEqual(VideoPlayer.AudioCodec,vorbis)">Vorbis</value>
	<value condition="String.IsEqual(VideoPlayer.AudioCodec,wavpack)">WAVP</value>
    <value>$INFO[VideoPlayer.AudioCodec,[UPPERCASE],[/UPPERCASE]]</value>
</variable>

IE: Dolby TrueHD
i would like to display:Dolby Atmos (Dolby TrueHD)

like you are doing on the DialogVideoInfo.xml

77

Plain and simple: No. There are no infolabels for 3D audio in Kodi. The media flags for 3D audio are only generated based on filename which is less than ideal, but the only way possible.

78

so i cannot pull the 3D Audio label from the file name during playback?

79

That wouldn’t make any sense as you don’t know whether the currently played track is actually the 3D audio track in question. You might then e.g. show an Atmos track is playing although the current audio track is the secondary TrueHD track which isn’t an Atmos track. This would lead to confusion.

With the media flags I use this approach: A user adds the Atmos, DTS:X or AURO-3D tag to the filename. The media flags in video info dialog (first page) and the video navigation only show information for the first audio track. I then check whether the tag is present in the filename and whether the first audio track is a matching base track (TrueHD/DD+ for Atmos, DTS-HD MA/HRA for DTS:X, etc.). Only if this is a match, the 3D audio label is shown for the first audio track.
During playback, the currently played track can be the seconds, third or whatever audio track which we definitely don’t know whether it’s actually a 3D audio track at all (as the logic for the filename only applies for the first audio track!). Therefore, I don’t show the 3D audio flags in the second video info screen either.

81

ok,

but in my situation i only save the Atmos(TrueHD) track, and if the File Has Atmos it Plays as Atmos!

thats why i ask, i am modding this skin for me and my situation!

so if the filename has Atmos, DTSX in it, can i pass that to the player info screen?

82

No need to quote the whole post :wink:

You could do that, yes. The code for the 3D labels is to be found in Variables.xml in line 890. The check only works with ListItem which checks the item in a list in the video library or the video info dialog atm. For this to work in the video player, you’d need to duplicate (and rename) the variable and you’d need to replace ListItem with Player. Additionally, you’d have to replace $VAR[AudioCodec] and $VAR[AudioChannels] used in said variable with $VAR[VideoPlayerAudioCodec] and $VAR[VideoPlayerAudioChannels].

Using this new variable in the video player OSD elements should give you what you want, I believe.

I have to be very frank: Getting to know the skin and working with it more or less blindly at this stage took me weeks and months of work. Time that I had to borrow from the spare time I have. Looking at the Kodi wiki and following the logic of the skin code step by step was necessary to get to this point although it was hard and sometimes massively frustrating. At the moment, I don’t have more time than before and I’m still doing improvement work on the skin (see the various threads that I’m active in here). This thread is, by far, taking the most time to reply to.

Long story short: Please get to know the Kodi skinning wiki (which I’ve linked to here already) and the skin code on your own and in your own pace. I can’t afford to give you huge parts of the changes you’re doing only for yourself. This is time I don’t have for working on the actual skin which is meant to be for thousands of users out there. I hope, you understand that this is not meant to be rude, but I simply have limited amounts of time at my disposal - and I had to go the same way myself already without any help at all. It’s not impossible :wink:

1 Like
85

thank you, im not asking for you to do it for me, it’s your skin so i figured you would have the best insight on where to go.

i have read the wiki several times now.

sorry to take up your time.

86

After looking into your approach, it was way over complicated. i just added a few lines to my existing variable and it works perfectly. Thank you for all your help!

See lines marked **

<variable name="VideoPlayerAudioCodec">
	<value condition="String.IsEqual(VideoPlayer.AudioCodec,aac) | String.IsEqual(VideoPlayer.AudioCodec,aac_latm)">AAC</value>
	<value condition="String.IsEqual(VideoPlayer.AudioCodec,ac3)">Dolby Digital</value>
	<value condition="String.IsEqual(VideoPlayer.AudioCodec,aif) | String.IsEqual(VideoPlayer.AudioCodec,aiff)">AIFF</value>
	<value condition="String.IsEqual(VideoPlayer.AudioCodec,alac)">Apple</value>
	<value condition="String.IsEqual(VideoPlayer.AudioCodec,cdda)">Audio-CD</value>
	<value condition="String.IsEqual(VideoPlayer.AudioCodec,dca) | String.IsEqual(VideoPlayer.AudioCodec,dts)">DTS</value>
	<value condition="String.IsEqual(VideoPlayer.AudioCodec,dolbydigital)">Dolby Digital</value>
	<value condition="String.StartsWith(VideoPlayer.AudioCodec,dsd)">DSD</value>
**  <value condition="[String.Contains(Player.Filenameandpath,_DTS-X.) + String.IsEqual(VideoPlayer.AudioCodec,dtshd_hra)]">DTS-X (DTS-HD HRA)</value>
	<value condition="String.IsEqual(VideoPlayer.AudioCodec,dtshd_hra)">DTS-HD HRA</value>
**  <value condition="[String.Contains(Player.Filenameandpath,_DTS-X.) + String.IsEqual(VideoPlayer.AudioCodec,dtshd_ma)]">DTS-X (DTS-HD MA)</value>
	<value condition="String.IsEqual(VideoPlayer.AudioCodec,dtshd_ma) | String.IsEqual(VideoPlayer.AudioCodec,dtsma)">DTS-HD MA</value>
	<value condition="String.IsEqual(VideoPlayer.AudioCodec,eac3)">Dolby Digital+</value>
	<value condition="String.IsEqual(VideoPlayer.AudioCodec,mp3float)">MP3</value>
	<value condition="String.IsEqual(VideoPlayer.AudioCodec,opus)">Opus</value>
	<value condition="String.IsEqual(VideoPlayer.AudioCodec,pcm) | String.IsEqual(VideoPlayer.AudioCodec,pcm_bluray) | String.IsEqual(VideoPlayer.AudioCodec,pcm_s16le) | String.IsEqual(VideoPlayer.AudioCodec,pcm_s24le)">PCM</value>
**  <value condition="[String.Contains(Player.Filenameandpath,_Atmos.) + String.IsEqual(VideoPlayer.AudioCodec,truehd)]">Dolby Atmos (Dolby TrueHD)</value>
	<value condition="String.IsEqual(VideoPlayer.AudioCodec,truehd)">Dolby TrueHD</value>
	<value condition="String.IsEqual(VideoPlayer.AudioCodec,vorbis)">Vorbis</value>
	<value condition="String.IsEqual(VideoPlayer.AudioCodec,wavpack)">WAVP</value>
	<value condition="String.IsEqual(VideoPlayer.AudioCodec,wma) | String.IsEqual(VideoPlayer.AudioCodec,wmapro) | String.IsEqual(VideoPlayer.AudioCodec,wmav2)">WMA</value>
	<value>$INFO[VideoPlayer.AudioCodec]</value>
</variable>
87

Well, my approach covers all possible ways of writing Atmos, DTS:X and AURO-3D, keeping the Kodi wiki guide for filenaming in mind :slightly_smiling_face: Had to go complicated for that…

A copy-paste and replace would’ve done it for you. But if you know exactly how to name the files, that’s sufficient, I guess. :wink:

88

In the past, in the Music view, Kodi would display a white square next to an album that had been played. Since the upgrade to Kodi 18, this no longer appears. Has the OSMC skin not been updated to match a new Kodi API in this regard, or has the “album has been played” functionality disappeared from Kodi completely?

89

The white dots that indicate if and how much of a video I have played are still there for me for video files I don’t know about audio

90

The functionality for music has indeed been removed from our skin as it was not consistent. But I’ve thought of ways to re-introduce it… My thought was that simply a “listened to” marker (similar or the same as the “watched” marker for videos) is not perfect. A play counter would be much more useful, I’m convinced.

Will keep this on the list and will play around with different ideas :+1:t2: