I had also spotted that kodi did not receive a version bump. I was hoping for the fixes brought by these 2 commits:
committed 05:36AM - 26 Jun 19 UTC
[PVR] Fix component dependencies: CPVRManager::IsPlayingChannel(int i…
committed 04:13PM - 29 Jun 19 UTC
[PVR] PVRRecordings: Prevent concurrent calls to video database.
No problems though, i’ve built a custom version using the tip of leia. I also add a custom patch anyhow to backport some work i did upstream for matrix:
xbmc:master
← jahutchi:pvr-is-playing-active-recording
opened 08:26AM - 03 Jul 19 UTC
## Description
This adds a new bool: PVR.IsPlayingActiveRecording which will be… set to true when kodi is currently playing a recording that is In-Progress.
## Motivation and Context
Currently, there are bools that can be used in the skin to tell whether a recording is playing: Pvr.IsPlayingRecording, or if there is currently a recording in progress (which could be on some other channel): Pvr.IsRecording.
There is also Pvr.IsRecordingPlayingChannel, but this is only set to true when you play a channel (livetv) which has an in-progress recording; and not when you playback an in-progress recording from the start (i.e. from the PVRRecordings window)
## How Has This Been Tested?
Playback an In-Progress recording from the PVR Recordings window & press the "Info" button.
Prior to this patch, there was no indication that you are playing an in-progress recording.
After this patch, you will see that the "Currently Recording" text and icon is displayed on the bottom bar, so you can now tell that you are playing back a recording that is in-progress.
## Screenshots (if appropriate):
Prior to the patch:
![screenshot016](https://user-images.githubusercontent.com/14977362/60575537-a239af00-9d73-11e9-86cc-51719d04ade0.png)
After the patch
![screenshot017](https://user-images.githubusercontent.com/14977362/60575570-b382bb80-9d73-11e9-9654-4116378c26d4.png)
Note: Ignore the "Noise" top-right of the screen - not sure why this occurred in the screenshot as it didn't display this way on-screen. Take notice of the icon bottom-left, which now shows for this in-progress recording.
## Types of change
- [ ] **Bug fix** (non-breaking change which fixes an issue)
- [ ] **Clean up** (non-breaking change which removes non-working, unmaintained functionality)
- [x] **Improvement** (non-breaking change which improves existing functionality)
- [ ] **New feature** (non-breaking change which adds functionality)
- [ ] **Breaking change** (fix or feature that will cause existing functionality to change)
- [ ] **Cosmetic change** (non-breaking change that doesn't touch code)
- [ ] **None of the above** (please explain below)
## Checklist:
- [x] My code follows the **[Code Guidelines](https://github.com/xbmc/xbmc/blob/master/docs/CODE_GUIDELINES.md)** of this project
- [x] My change requires a change to the documentation, either Doxygen or wiki
- [x] I have updated the documentation accordingly
- [x] I have read the **[Contributing](https://github.com/xbmc/xbmc/blob/master/docs/CONTRIBUTING.md)** document
- [x] I have added tests to cover my change
- [x] All new and existing tests passed
1 Like
I’m waiting for Kodi v18.4 which should be ready by the end of the month.
I can give this a bump in the staging repository if you’d like
Sam
I’m good, my custom build with leia bump is working nicely so will probably stick there until 18.4 becomes official.
Would however be nice to get this backported:
xbmc:master
← jahutchi:pvr-is-playing-active-recording
opened 08:26AM - 03 Jul 19 UTC
## Description
This adds a new bool: PVR.IsPlayingActiveRecording which will be… set to true when kodi is currently playing a recording that is In-Progress.
## Motivation and Context
Currently, there are bools that can be used in the skin to tell whether a recording is playing: Pvr.IsPlayingRecording, or if there is currently a recording in progress (which could be on some other channel): Pvr.IsRecording.
There is also Pvr.IsRecordingPlayingChannel, but this is only set to true when you play a channel (livetv) which has an in-progress recording; and not when you playback an in-progress recording from the start (i.e. from the PVRRecordings window)
## How Has This Been Tested?
Playback an In-Progress recording from the PVR Recordings window & press the "Info" button.
Prior to this patch, there was no indication that you are playing an in-progress recording.
After this patch, you will see that the "Currently Recording" text and icon is displayed on the bottom bar, so you can now tell that you are playing back a recording that is in-progress.
## Screenshots (if appropriate):
Prior to the patch:
![screenshot016](https://user-images.githubusercontent.com/14977362/60575537-a239af00-9d73-11e9-86cc-51719d04ade0.png)
After the patch
![screenshot017](https://user-images.githubusercontent.com/14977362/60575570-b382bb80-9d73-11e9-9654-4116378c26d4.png)
Note: Ignore the "Noise" top-right of the screen - not sure why this occurred in the screenshot as it didn't display this way on-screen. Take notice of the icon bottom-left, which now shows for this in-progress recording.
## Types of change
- [ ] **Bug fix** (non-breaking change which fixes an issue)
- [ ] **Clean up** (non-breaking change which removes non-working, unmaintained functionality)
- [x] **Improvement** (non-breaking change which improves existing functionality)
- [ ] **New feature** (non-breaking change which adds functionality)
- [ ] **Breaking change** (fix or feature that will cause existing functionality to change)
- [ ] **Cosmetic change** (non-breaking change that doesn't touch code)
- [ ] **None of the above** (please explain below)
## Checklist:
- [x] My code follows the **[Code Guidelines](https://github.com/xbmc/xbmc/blob/master/docs/CODE_GUIDELINES.md)** of this project
- [x] My change requires a change to the documentation, either Doxygen or wiki
- [x] I have updated the documentation accordingly
- [x] I have read the **[Contributing](https://github.com/xbmc/xbmc/blob/master/docs/CONTRIBUTING.md)** document
- [x] I have added tests to cover my change
- [x] All new and existing tests passed
Dont worry if not, I can continue pulling from git and doing my own builds until matrix eventually is released.
Can you PR a backport to Kodi?
Might be worth asking if they will accept it first.
Sam
As its not a bugfix theres little to no chance a backport would be accepted, otherwise would have created one earlier.
No problems, happy to wait until matrix, and create custom builds in the intrim.
1 Like
No new features regarding the skin engine will be backported by Kodi unfortunately.
@chillbo might twist my arm and get me to backport skin engine improvements anyway…
Sam
2 Likes
So happy with the coming support / test builds with 3D MVC support.
This is a long wish, since early 2018, so happy to see great progress has been made on this! Thank you.
Frido
7 August 2019 08:50
31
Thank
U Sam —Great Support !
Hi, I’m using OSMC on RPi 2B and I noticed that the system hangs for a while when I reboot or shutdown. It hangs on “Reached target shutdown”.
This started when OSMC updated to the july release. Maybe it’s just a coincidence, but before the update I didn’t notice any delays.
Anyone experienced this behavior?
Haven’t noticed this issue. Can you reproduce it on a fresh installation?
nls
7 August 2019 17:16
34
I don’t really understand the question. You’re pointing to an issue, rather than a fix or commit.
Thanks for the great update Sam. Image quality of live TV has improved significantly (wobbling of subs/lines is gone).
Looking forward to HLG support, to watch formula 1 in 4K HDR quality (RTL UHD channel). Now I’m forced to fallback to IPTV app running at TV.
Support for Hybrid-Log-Gamma will come with a kernel update at the end of the Summer. We’ll make testing available soon.
Cheers
Sam
1 Like
I’ll try to do it. The OSMC installer does not have the july release available for selection yet. So I’ll install the previous one (june) and then I will update to the july release via My OSMC. Will get back with the results.
The July images will be available in a few hours, I’m building them now.
OK, I’ll wait then. Thanks.
What exactly does this refer to, any link?
There were a couple of reports on the forum about this. I don’t have a link at hand unfortunately