Problems detecting and handling deinterlacing and pulldown

All of the latest changes should now be built and available. You’ll still need to have the staging repository active as before. It will take about 10-15 minutes for the repository to synchronise.

Keep in mind that it deactivates after 14 days. I know it’s only been a week, but depending on whether there are further additional changes in the coming days, it’s something worth remembering if you stop getting updates.

Sam

The new build passes the Timeflight test on the V :slight_smile: - thanks to all concerned, this is a substantial improvement for native SD 50i over the current production version, I really appreciate the effort.

In relation to this comment from earlier in the thread, I do see the logic in defaulting to deinterlacing everything, provided an option is retained to disable deinterlacing, at least for VC-1. For my VC-1 go-to test of the Matt Smith Dr Who “Time of Angels”, with deinterlace set to Auto I’m seeing some stutter, as if the player is not sure what to do. If that went out to wide release I could see how there could be complaints. Switching on deinterlacing fixes the motion but there are some moire artefacts, but casual users might not care, and for the seriously picky user all you have to do is disable deinterlacing and you get perfect, moire-free playback. Appreciate best efforts have been made to mirror this for h264, but I’m sure most users would find the playback more than acceptable, even if it’s not absolutely the last word in what’s possible for frame-interlaced h264.

2 Likes

This is more common now then ever that TVs will accept 1080p120 but wouldn’t that just create the problem that then the Vero has to handle scaling the SD content to 1080 and if I remember correctly you were not happy with how well that looked.

I have some DVD remux files I tried this with.
Old TV show DVDs were authored notoriously poor.
There’s this show called Millennium, from Chris Carter of The X-Files, and the content of the show is 24fps but the title sequence is in 30fps so I figured having the Vero output at 1080p120 might fix it, but it didn’t.
I even tried reencoding it at 120 FPS with Handbrake but that took forever and the files were even larger than the original remuxes.

Personally, I would love to see Vero have a 120 FPS solution if it wasn’t too difficult to implement.

I’m told the Vero V has better quality upscaling than the Vero 4K. Might not be as much of an issue there.

What’s your best test clip for upscaling?
I’ll check it out.

These changes are now part of OSMC’s December update.

Thank you for your reports.

Sam

Sorry, to resurrect this thread, @grahamh but I said before:

I spotted this post in another thread:

This command fixes the problem I was talking about in the post I just quoted, and makes things as sharp as they used to be a couple of months ago, instead of more shimmery. Unfortunately the command also disables the newly-enabled diagonal filtering that looks so nice on hardware-decoded field-interlaced DVD remuxes.

It’s possible that’s not a coincidence, and that turning on diagonal filtering makes cases where the deinterlacer goes into field-interlaced mode when it shouldn’t look worse than they used to. It’s also possible that there’s some other additional post-processing being enabled as well, and both that and the diagonal filtering are deactivated by that command. But whatever is happening, there’s a definite association between those two things.

I don’t know if the issue kallek was complaining about in the other thread is the same thing I was grumbling about. Maybe! :slight_smile:

Yeah, they must be related. We did nearly all our testing on Vero V which doesn’t show these ‘sharpening’ type effects. I think @tanio99 has shared with you before the millions of parameters that influence the deinterlacer module. Many with ‘dnr’ in their name and all with zero documentation. So picking out the ones that need tweaking is next to impossible. I’m not sure there’s the will to spend more time on it if it only affects a, ahem, legacy device.

Needless to say, AML have zero interest in making sure the newer kernels work with older hw.

Just my personal thinking. I don’t work here :innocent:

We-ell, I can’t speak for anyone else, but if the price of good deinterlacing is messing up progressive stuff, that’s a price that may not be worth paying. Could be you’d be better going back to the old way of doing things on Vero 4K.

If it helps at all, I seem to remember there was a parameter called something like “reduce jaggies” - could be that’s the one you want to preserve? At any rate it seems unlikely you want to activate anything with “DNR” in the name!

Indeed

We have clear improvements on Vero V, and as our last release for Vero 4K + will be Kodi v21, this will probably be the best time to sunset Vero 4K + support.

Cheers

Sam

It’s possible that bypass_all doesn’t do what it implies. Can you confirm that your deinterlaced clips actually get worse if that parameter is set?

It doesn’t turn off deinterlacing - on a field-interlaced clip I don’t start seeing combing - but it certainly does turn off diagonal filtering. So on my Time Flight clip, for example, it makes the crawling jagged edges on the control console come back. On the other hand, it does improve (or rather restore) video quality on (for example) my Sherlock clip.

So basically bypass_all makes frame-interlaced (and I think progressive?) stuff look better, but makes field-interlaced stuff look worse.

1 Like